Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Formbricks survey from SDK #4217

Merged
merged 3 commits into from
Mar 28, 2024
Merged

Use Formbricks survey from SDK #4217

merged 3 commits into from
Mar 28, 2024

Conversation

Soare-Robert-Daniel
Copy link
Contributor

@Soare-Robert-Daniel Soare-Robert-Daniel commented Mar 25, 2024 •
edited
Loading

Summary

  • Remove Formbricks from NPM deps.
  • Use Formbricks version from SDK.

Note

I renamed the E2E folder tpc to admin to include the test for the survey since both TPC and survey are a part of the dashboard, which is an admin page.

Will affect visual aspect of the product

NO

Screenshots

Screenshot 2024-03-25 at 11 59 18 Screenshot 2024-03-25 at 11 59 39

Test instructions

  • Check if the survey_deps.js script is loaded.
  • Check if the request to Formbricks are made.

Check before Pull Request is ready:

Closes https://github.com/Codeinwp/themeisle/issues/1635

@Soare-Robert-Daniel Soare-Robert-Daniel self-assigned this Mar 25, 2024
@Soare-Robert-Daniel Soare-Robert-Daniel added the pr-checklist-skip Allow this Pull Request to skip checklist. label Mar 25, 2024
@Soare-Robert-Daniel Soare-Robert-Daniel marked this pull request as ready for review March 25, 2024 10:08
@pirate-bot
Copy link
Collaborator

pirate-bot commented Mar 25, 2024 •
edited
Loading

Plugin build for 82c4f6a is ready 🛎️!

@pirate-bot pirate-bot added the pr-checklist-complete The Pull Request checklist is complete. (automatic label) label Mar 25, 2024
@preda-bogdan preda-bogdan removed the pr-checklist-skip Allow this Pull Request to skip checklist. label Mar 27, 2024
@preda-bogdan preda-bogdan merged commit 6fa26d4 into development Mar 28, 2024
23 checks passed
@preda-bogdan preda-bogdan deleted the fix/formbricks-loading branch March 28, 2024 11:26
@pirate-bot
Copy link
Collaborator

🎉 This PR is included in version 3.8.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@preda-bogdan preda-bogdan preda-bogdan approved these changes

Assignees

@Soare-Robert-Daniel Soare-Robert-Daniel

Labels
pr-checklist-complete The Pull Request checklist is complete. (automatic label) released Indicate that an issue has been resolved and released in a particular version of the product.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Soare-Robert-Daniel @pirate-bot @preda-bogdan